-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
argc: support cross-compilation #305729
argc: support cross-compilation #305729
Conversation
The Darwin cross-compilation test cases are affected by #273442 and fails to evaluate (infinite recursion). Here are the reason why I still add them:
|
edfcb18
to
7a746be
Compare
Think this looks ok, but would like another pair of eyes |
@SuperSandro2000 Some diffs mentioned in the reviews are caused by the formatter. Should I also refactor them in this PR? |
I would prefer to do less formatting changes to make the review easier but whatever you prefer. |
Next time I'll split out the formatting changes when working on similar features. Given that the the formatted changes has been reviewed, I'm adding a commit to address them. |
Co-authored-by: Sandro <[email protected]>
Use native argc to generate shell completion files when "$out/bin/argc" cannot be executed on the build platform.
@SuperSandro2000 Many thanks to you for reviewing this PR and polishing it! |
Description of changes
nixfmt
in accordance with [RFC 0166] Nix formatting, take two rfcs#166.stdenv.buildPlatform.canExecute stdenv.hostPlatform
."${!outputBin}/bin"
into thePATH
used byinstallShellCompletion
. (SuchPATH
value is namedINSTALL_SHELL_FILE_PATH
, so that we could generate and install man pages after argc 1.16).argcNative
intonativeBuildInputs
anddisallowedRequisites
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.